Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding section about rust-analyzer in README #4

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

thepacketgeek
Copy link
Contributor

Redo of PR #2 to just update docs & .gitignore with details for rust-analyzer & rust-project.json

Depends on Rust-for-Linux/linux#914 for out-of-tree rust-analyzer support

Copy link
Member

@ojeda ojeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! A couple nits below to keep things a bit more consistent.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@thepacketgeek thepacketgeek force-pushed the generate-rust-project branch 2 times, most recently from 07f6906 to 3488c23 Compare January 24, 2023 18:21
Copy link
Member

@ojeda ojeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, for this repository does not matter much because it most likely not go into the kernel, but it would still be nice if you could sign your commits with Signed-off-by to simplify things! Please see the DCO https://www.kernel.org/doc/html/latest/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin

README.md Outdated Show resolved Hide resolved
- Including an example of how to create a rust-analyzer `rust-project.json` config
- Adding `rust-project.json` to `.gitignore`

Signed-off-by: Matthew Wood <mat@thepacketgeek.com>
@thepacketgeek
Copy link
Contributor Author

Thanks again for the tips, I've signed off this commit

@ojeda
Copy link
Member

ojeda commented Jan 24, 2023

My pleasure!

@ojeda ojeda merged commit 490d67b into Rust-for-Linux:main Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants